feat(iam): add 'service-accounts' listing page #22179
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcMonchablon
requested review from
Steffy29,
aderghamov,
chipp972,
darsene,
mhelhali-soufien,
qpavy and
yjaaouane
darsene
reviewed
Feb 10, 2026
Comment on lines
+5
to
+7
| "iam_identities_service_accounts": "Compte de service", | ||
| "iam_identities_sso": "SSO", | ||
| "iam_service_accounts_breadcrumb_service_accounts": "Compte de service", |
Contributor
There was a problem hiding this comment.
Why not use only one translation to manage the breadcrumb? Moreover, you don't use specific key for other breadcrumb elements.
Suggested change
| "iam_identities_service_accounts": "Compte de service", | |
| "iam_identities_sso": "SSO", | |
| "iam_service_accounts_breadcrumb_service_accounts": "Compte de service", | |
| "iam_identities_service_accounts": "Compte de service", | |
| "iam_identities_sso": "SSO", |
| href={identitiesHref} | ||
| /> | ||
| <OdsBreadcrumbItem | ||
| label={t('iam_service_accounts_breadcrumb_service_accounts', { |
Contributor
There was a problem hiding this comment.
Suggested change
| label={t('iam_service_accounts_breadcrumb_service_accounts', { | |
| label={t('iam_identities_service_accounts', { |
Comment on lines
+9
to
+22
| export const useIamServiceAccountList = ({ | ||
| columns, | ||
| pageSize, | ||
| }: { | ||
| columns: DatagridColumn<IamServiceAccount>[]; | ||
| pageSize: number; | ||
| }) => { | ||
| const route = '/me/api/oauth2/client'; | ||
| return useResourcesIcebergV6<IamServiceAccount>({ | ||
| route, | ||
| queryKey: getIamServiceAccountListQueryKey(), | ||
| columns, | ||
| pageSize, | ||
| }); |
Contributor
There was a problem hiding this comment.
Suggested change
| export const useIamServiceAccountList = ({ | |
| columns, | |
| pageSize, | |
| }: { | |
| columns: DatagridColumn<IamServiceAccount>[]; | |
| pageSize: number; | |
| }) => { | |
| const route = '/me/api/oauth2/client'; | |
| return useResourcesIcebergV6<IamServiceAccount>({ | |
| route, | |
| queryKey: getIamServiceAccountListQueryKey(), | |
| columns, | |
| pageSize, | |
| }); | |
| const authRoute = '/me/api/oauth2/client'; | |
| export const useIamServiceAccountList = ({ | |
| columns, | |
| pageSize, | |
| }: { | |
| columns: DatagridColumn<IamServiceAccount>[]; | |
| pageSize: number; | |
| }) => { | |
| return useResourcesIcebergV6<IamServiceAccount>({ | |
| route: authRoute, | |
| queryKey: getIamServiceAccountListQueryKey(), | |
| columns, | |
| pageSize, | |
| }); |
Comment on lines
11
to
12
| // TODO: load policy count | ||
| console.log('account: ', account); |
Contributor
There was a problem hiding this comment.
Not doable yet?
Shell plugin provides a logger if needed. Better than using console.log
| import { OdsTabs, OdsTab } from '@ovhcloud/ods-components/react'; | ||
|
|
||
| export function ServiceAccountsTabs() { | ||
| // TODO |
| manualSorting={false} | ||
| search={search} | ||
| contentAlignLeft | ||
| getRowId={(token) => token.name} |
Contributor
There was a problem hiding this comment.
Suggested change
| getRowId={(token) => token.name} | |
| getRowId={({name}) => name} |
Comment on lines
+10
to
+12
| import { IamServiceAccount } from '@/data/api/iam-service-accounts'; | ||
| import { Actions } from './Actions.component'; | ||
| import { ServiceAccountsPolicyCount } from '../components/ServiceAccountsPolicyCount.component'; |
| const { t } = useTranslation('permanent-tokens'); | ||
| const formatDate = useFormatDate(); | ||
|
|
||
| return [ |
ref: #MAIAM-81 Signed-off-by: Marc Monchablon <marc.monchablon.ext@corp.ovh.com>
MarcMonchablon
force-pushed
the
feat/MAIAM-81
branch
from
4d06084 to
65b9327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #MAIAM-81
Description
Ticket Reference: #...
Additional Information