fix(vcfaas): display ip block tiles only if standard offer #22196
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: #MANAGER-20823 Signed-off-by: ahmed sefiani <ahmed.sefiani.ext@corp.ovh.com>
pauldkn
approved these changes
Feb 10, 2026
tibs245
reviewed
Feb 10, 2026
| } | ||
|
|
||
| const currentState = vcdDatacentre?.data?.currentState; | ||
| const displayPublicIpBlocksTile = |
Contributor
There was a problem hiding this comment.
Suggested change
| const displayPublicIpBlocksTile = | |
| const showPublicIpBlocksTile = |
Suggested change
| const displayPublicIpBlocksTile = | |
| const isPublicIpBlocksTileDisplayed = |
Contributor
There was a problem hiding this comment.
You can create a very little function to avoid declare 2 cont :
const isStandard = (currentState) => !!currentState?.vrack && currentState?.commercialRange === 'STANDARD';And in bonus it's testabled 😇
tibs245
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #MANAGER-20823