Skip to content

static query hooks fixes: modelOptions in DelegateOperation should forward to the one from the delegated operation, resolve modelOptions.old properly for graph operations#18

Merged
falkenhawk merged 1 commit intomainfrom
fix-delegate-model-options-local
Dec 16, 2024

Conversation

@falkenhawk
Copy link
Member

modelOptions in DelegateOperation should forward to the one from the delegated operation

  • to make modelOptions always available in static query hooks, also when using upsertGraph(AndFetch) and patchAndFetchById
  • also fix the query builder being executed on the model built from a graph instead of the source(current) model - the modelOptions.old should contain the old values read from db, not the new ones from the graph.

@falkenhawk falkenhawk force-pushed the fix-delegate-model-options-local branch from e70f401 to 6b67efc Compare December 16, 2024 08:44
@falkenhawk falkenhawk requested a review from flipace December 16, 2024 10:58
@falkenhawk falkenhawk self-assigned this Dec 16, 2024
Copy link
Member

@flipace flipace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤓

the delegated operation
- to make `modelOptions` always available in static query hooks, also when using upsertGraph(AndFetch) and patchAndFetchById
- also fix the query builder being executed on the model built from a graph instead of the source(current) model - the modelOptions.old should contain the old values read from db, not the new ones from the graph.
@falkenhawk falkenhawk force-pushed the fix-delegate-model-options-local branch from 8081721 to ad9c72c Compare December 16, 2024 12:09
@falkenhawk
Copy link
Member Author

also submitted upstream: Vincit#2730

@falkenhawk falkenhawk merged commit 8abe07c into main Dec 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants