lbfgs: fix check_work #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got this error, which doesn't make sense because 2 is <= 2:
```
Fatal error: exception Failure("Lbfgs.min: dim of work too small for problem size n = 2, valid n <= 2")
```
iwa is allocated as 3*n, and upstream L-BFGS-ocaml checks for 3*n too,
the check against 3*corrections seems to be a typo, looking at lbfgsb.f
says '3*nmax' and the code has `iwa.(2*n+1)` so clearly related to 'n'
and not 'corrections'.
Signed-off-by: Edwin Török <edwin@etorok.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got this error, which doesn't make sense because 2 is <= 2:
iwa is allocated as 3n, and upstream L-BFGS-ocaml checks for 3n too, the check against 3corrections seems to be a typo, looking at lbfgsb.f says '3nmax' and the code has
iwa.(2*n+1)so clearly related to 'n' and not 'corrections'.