Wrap calls to setAccessible in try-catch#178
Open
nicky9door wants to merge 1 commit intoowlike:masterfrom
Open
Wrap calls to setAccessible in try-catch#178nicky9door wants to merge 1 commit intoowlike:masterfrom
nicky9door wants to merge 1 commit intoowlike:masterfrom
Conversation
This was referenced Jan 21, 2022
Closed
Contributor
|
I have a strong preference for the other way of doing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative fix for #173 where the call to setAccessible is wrapped in a try-catch. I am catching
Exceptioninstead ofInaccessibleObjectExceptionsince the latter is only available since Java 9. This way, the code remains backwards compatible with Java 8Feel free to choose between this PR or #177