-
Notifications
You must be signed in to change notification settings - Fork 45
chore: minor code cleanup #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR performs repository maintenance by updating Cargo.toml metadata, adding linting configurations, and cleaning up code based on clippy suggestions.
Changes:
- Added
publish = falseto testing crate manifests to prevent accidental publication - Added keywords and categories metadata to main package manifests for better discoverability
- Configured workspace-level Rust and Clippy lints (forbid unsafe code, enable pedantic warnings with selective allows)
- Refactored code to reduce duplication (consolidated
writeln!calls, unified name sanitization logic) - Fixed spelling and documentation formatting issues
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| testing/rust-integration/Cargo.toml | Added publish = false to prevent accidental publication |
| testing/cantools-messages/Cargo.toml | Added publish = false to prevent accidental publication |
| testing/can-messages/Cargo.toml | Added publish = false to prevent accidental publication |
| testing/can-embedded/Cargo.toml | Added publish = false to prevent accidental publication |
| fuzz/Cargo.toml | Reordered fields for consistency (moved edition before publish) |
| dbc-codegen-cli/Cargo.toml | Added metadata (keywords, categories), reordered fields, removed unused heck dependency |
| Cargo.toml | Added metadata (keywords, categories) and comprehensive linting configurations |
| src/lib.rs | Code cleanup: simplified writeln! calls, consolidated name sanitization, improved variable naming, fixed spelling and documentation |
| src/pad.rs | Added clippy allow attribute for intentional code pattern |
| README.md | Improved documentation formatting with consistent backticks |
| Cargo.lock | Routine dependency version updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trnila
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just commits are quite big - especially with squashing strategy
|
@trnila |
Uh oh!
There was an error while loading. Please reload this page.