Skip to content

Conversation

@nyurik
Copy link
Member

@nyurik nyurik commented Jan 11, 2026

  • cleanup a few code dups, clippy suggestions
  • disable test crate publishing
  • add keywords and categories

@nyurik nyurik marked this pull request as ready for review January 12, 2026 16:36
@nyurik nyurik requested review from Copilot, tegimeki and trnila January 12, 2026 16:36
@nyurik nyurik changed the title chore: update Cargo.toml with metadata and linting configurations chore: cleanup some simple code fixes, Cargo.tomls Jan 12, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs repository maintenance by updating Cargo.toml metadata, adding linting configurations, and cleaning up code based on clippy suggestions.

Changes:

  • Added publish = false to testing crate manifests to prevent accidental publication
  • Added keywords and categories metadata to main package manifests for better discoverability
  • Configured workspace-level Rust and Clippy lints (forbid unsafe code, enable pedantic warnings with selective allows)
  • Refactored code to reduce duplication (consolidated writeln! calls, unified name sanitization logic)
  • Fixed spelling and documentation formatting issues

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
testing/rust-integration/Cargo.toml Added publish = false to prevent accidental publication
testing/cantools-messages/Cargo.toml Added publish = false to prevent accidental publication
testing/can-messages/Cargo.toml Added publish = false to prevent accidental publication
testing/can-embedded/Cargo.toml Added publish = false to prevent accidental publication
fuzz/Cargo.toml Reordered fields for consistency (moved edition before publish)
dbc-codegen-cli/Cargo.toml Added metadata (keywords, categories), reordered fields, removed unused heck dependency
Cargo.toml Added metadata (keywords, categories) and comprehensive linting configurations
src/lib.rs Code cleanup: simplified writeln! calls, consolidated name sanitization, improved variable naming, fixed spelling and documentation
src/pad.rs Added clippy allow attribute for intentional code pattern
README.md Improved documentation formatting with consistent backticks
Cargo.lock Routine dependency version updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nyurik nyurik changed the title chore: cleanup some simple code fixes, Cargo.tomls chore: minor code cleanup Jan 12, 2026
Copy link
Member

@trnila trnila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just commits are quite big - especially with squashing strategy

@nyurik
Copy link
Member Author

nyurik commented Jan 13, 2026

@trnila +274 −282 seems like a fairly small commit. The big ones will come only when we start modifying what code gets generated from the test files. That's why i make sure to ignore the real .dbc files from opendbc - they are far larger, and generate significantly more churn.

@nyurik nyurik merged commit a644be3 into oxibus:main Jan 13, 2026
4 checks passed
@nyurik nyurik deleted the linting branch January 13, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants