-
Notifications
You must be signed in to change notification settings - Fork 18
Add tabs to access pages #2983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add tabs to access pages #2983
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I wonder if, since we show |
|
I backed out the change to show the modal and the members of the group, as well as the members count column, until we have the updated API with the members count in it, so we can lazy-load the members list and avoid an n+1 on the table. |

This PR splits the Silo Access and Project Access pages into tabs, so a viewer can see the roles broken down, showing just Users, just Groups, or All with access (and their respective roles). This also updates the forms on each tab's page, to show just "Add user", "Add group", or "Add user or group", depending on what tab it's shown on.
This is part of #2887, and will be useful for more detailed views of group member counts, user
time_modifiedvalues (as in oxidecomputer/omicron#9494), more comprehensive lists of users, etc. I wanted to get these changes in first, though, to keep future PRs tighter.The forms are slightly modified to make them more contextually-relevant as well. (Ignore the weird scaling difference due to the screenshot dimensions.)