Show a message that this site requires JavaScript #2989
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a noscript tag that displays a message that this site requires JavaScript to run. The easiest way to test this locally is to use Chrome since it can disable JavaScript per tab instead of globally. Open the dev console and click the gear icon and check "Disable "JavaScript" in the Debugger section. I skipped adding a test since it is a static change and playwright requires js to run. resolves oxidecomputer#2928
|
@oblakeerickson is attempting to deploy a commit to the Oxide Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
And this is how it looks: 
|
Collaborator
|
Thanks for getting this started. I tweaked the colors and layout a bit. 
|
Contributor
Author
|
Nice! I like it. |
Collaborator
|
It turns out we have the CSS in prod, just not in local dev, which loads the CSS through JS. You can test this with 2025-12-23-noscript.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a noscript tag that displays a message that this site requires JavaScript to run.
The easiest way to test this locally is to use Chrome since it can disable JavaScript per tab instead of globally. Open the dev console and click the gear icon and check "Disable "JavaScript" in the Debugger section.
I skipped adding a test since it is a static change and playwright requires js to run.
resolves #2928