[cockroach-admin-types] reorganize per RFD 619 #9529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
19 tasks
jgallagher
reviewed
Dec 17, 2025
| /// | ||
| /// Note: This is an internal type used for CLI parsing and internal | ||
| /// storage, distinct from the published API `NodeId` type in the | ||
| /// versions crate which has a different structure. |
Contributor
There was a problem hiding this comment.
Sorry if this is obvious and I'm missing it - why do we have separate NodeId and InternalNodeId now?
Contributor
Author
There was a problem hiding this comment.
Previously there were two node IDs, both called NodeId. I found that to be pretty confusing (and it became a bit worse with this change) so I changed the non-JSON-schema type to InternalNodeId. This isn't a functional change, just a rename of one of the NodeId types.
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.