Skip to content

Conversation

@sunshowers
Copy link
Contributor

@sunshowers sunshowers commented Dec 19, 2025

Update dropshot-api-manager to pull in the change for oxidecomputer/dropshot-api-manager#35 (see that issue for motivation and more discussion).

The Sled Agent API requires a bump. Some of the others would have, but we exclude client-side-versioned APIs from consideration for this bytewise equality check.

Diff of changes to the Sled Agent API: https://gist.github.com/sunshowers/a08bbea7b321fa2fbef714e3e54bde1d

Created using spr 1.3.6-beta.1
@sunshowers
Copy link
Contributor Author

If you don't do the bump, this is the message that gets produced: https://gist.github.com/sunshowers/5d0cb9a1b28fe897f7406b3268e97866#file-gistfile0-txt-L55

           error: For the latest blessed version, the OpenAPI document generated from the current code is wire-
                  compatible but not bytewise identical to the blessed document. This implies one or more trivial
                  changes such as type renames or documentation updates. To proceed, bump the API version in the
                  `api_versions!` macro; unless you're introducing other changes, there's no need to make changes to
                  any endpoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants