omdb db sql
#9554
Open
omdb db sql
#9554
+37
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepacheco
reviewed
Dec 19, 2025
Collaborator
davepacheco
left a comment
davepacheco
left a comment
There was a problem hiding this comment.
I'm very excited about this.
CockroachDB does have a default_transaction_read_only option. And it looks like you can pass --read-only to cockroach sql (and so presumably cockroach-sql):
--read-only
Set the session variable default_transaction_read_only to on.
But even if we do this for you, the user can just change it once you're in the SQL shell. I think what I'd suggest is to do both: require -w/--destructive in omdb and also pass --read-only when invoking cockroach-sql. I could be talked into not requiring the -w on omdb, on the argument that "if you set read-only off in the interactive shell, that's on you".
| source.packages = [ | ||
| "omicron-nexus.tar.gz", | ||
| "omicron-omdb.tar.gz", | ||
| "cockroachdb-sql.tar.gz", |
Collaborator
There was a problem hiding this comment.
Why is this in the Nexus zone?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9021.
Should probably also add and require the
-w(destructive) flag... (or perhaps there's some way I can tell cockroach-sql to set up a read-only session?)Not tested yet, had troubles with deploying to a racklette and I decided Friday afternoon is not the time to debug that.
Changes to oxidecomputer/cockroachdb (no source changes):
oxidecomputer/cockroach@80eed95
oxidecomputer/cockroach@367bca4