Skip to content

Add trust quorum reconfiguration endpoints to sled-agent API #9556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
plaidfinch wants to merge 3 commits into
base: main
Choose a base branch
from
+11,070 −3
Draft

Add trust quorum reconfiguration endpoints to sled-agent API #9556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ccf78a
Adds version 13 (`ADD_TRUST_QUORUM`) to the Sled Agent API
plaidfinch Dec 21, 2025
40eecf0
Stub out SledAgentApi methods in test utils for Nexus
plaidfinch Dec 21, 2025
9f00be2
Add trust quorum proxy endpoints and use `serde_with` for hex encoding
plaidfinch Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

99 changes: 99 additions & 0 deletions nexus/mgs-updates/src/test_util/host_phase_2_test_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,5 +936,104 @@ mod api_impl {
) -> Result<HttpResponseUpdatedNoContent, HttpError> {
unimplemented!()
}

async fn trust_quorum_reconfigure(
_request_context: RequestContext<Self::Context>,
_body: TypedBody<
sled_agent_types::trust_quorum::TrustQuorumReconfigureRequest,
>,
) -> Result<HttpResponseUpdatedNoContent, HttpError> {
unimplemented!()
}

async fn trust_quorum_upgrade_from_lrtq(
_request_context: RequestContext<Self::Context>,
_body: TypedBody<
sled_agent_types::trust_quorum::TrustQuorumLrtqUpgradeRequest,
>,
) -> Result<HttpResponseUpdatedNoContent, HttpError> {
unimplemented!()
}

async fn trust_quorum_commit(
_request_context: RequestContext<Self::Context>,
_body: TypedBody<
sled_agent_types::trust_quorum::TrustQuorumCommitRequest,
>,
) -> Result<
HttpResponseOk<
sled_agent_types::trust_quorum::TrustQuorumCommitResponse,
>,
HttpError,
> {
unimplemented!()
}

async fn trust_quorum_coordinator_status(
_request_context: RequestContext<Self::Context>,
) -> Result<
HttpResponseOk<
Option<sled_agent_types::trust_quorum::TrustQuorumCoordinatorStatus>,
>,
HttpError,
>{
unimplemented!()
}

async fn trust_quorum_prepare_and_commit(
_request_context: RequestContext<Self::Context>,
_body: TypedBody<
sled_agent_types::trust_quorum::TrustQuorumPrepareAndCommitRequest,
>,
) -> Result<
HttpResponseOk<
sled_agent_types::trust_quorum::TrustQuorumCommitResponse,
>,
HttpError,
> {
unimplemented!()
}

async fn trust_quorum_proxy_commit(
_request_context: RequestContext<Self::Context>,
_body: TypedBody<
sled_agent_types::trust_quorum::TrustQuorumProxyCommitRequest,
>,
) -> Result<
HttpResponseOk<
sled_agent_types::trust_quorum::TrustQuorumCommitResponse,
>,
HttpError,
> {
unimplemented!()
}

async fn trust_quorum_proxy_prepare_and_commit(
_request_context: RequestContext<Self::Context>,
_body: TypedBody<
sled_agent_types::trust_quorum::TrustQuorumProxyPrepareAndCommitRequest,
>,
) -> Result<
HttpResponseOk<
sled_agent_types::trust_quorum::TrustQuorumCommitResponse,
>,
HttpError,
> {
unimplemented!()
}

async fn trust_quorum_proxy_status(
_request_context: RequestContext<Self::Context>,
_body: TypedBody<
sled_agent_types::trust_quorum::TrustQuorumProxyStatusRequest,
>,
) -> Result<
HttpResponseOk<
sled_agent_types::trust_quorum::TrustQuorumNodeStatus,
>,
HttpError,
> {
unimplemented!()
}
Comment on lines +940 to +1037
Copy link
Contributor Author

@plaidfinch plaidfinch Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively leaving these unimplemented!() because the rest of this impl appears to do the same.

}
}
Loading
Loading