Skip to content

Fix RFD popover and directly link RFDs #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
benjaminleonard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix RFD popover and directly link RFDs #188

benjaminleonard wants to merge 3 commits into from

Conversation

@benjaminleonard
Copy link
Collaborator

@benjaminleonard benjaminleonard commented Jan 8, 2026 •
edited
Loading

Two things happening here:

  1. Fixes the RFD popover not showing up if you haven't hard refreshed the RFD. It does so by adding an event listener to the body rather than the individual a tags. The nearest check is so quick that I can't identify any meaningful performance loss even though it's called whenever the mouse moves across the body rather than the a tags
  2. Moves the delegated link hook into here, so I can identify RFD links and hijack them by navigating directly to the RFD rather than the bibliography.

@vercel
Copy link

vercel bot commented Jan 8, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
rfd-site Ready Ready Preview Jan 8, 2026 0:02am

@benjaminleonard benjaminleonard marked this pull request as ready for review January 8, 2026 12:10
@oxidecomputer oxidecomputer deleted a comment from bhaktatejas922 Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@benjaminleonard