Skip to content

style: remove needless pass by value #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danieleades wants to merge 2 commits into
base: main
Choose a base branch
from
+201 −181
Open

style: remove needless pass by value #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97beeb2
style: remove needless pass by value
danieleades Dec 20, 2025
22e9ca5
enforce lint
danieleades Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,6 @@ thiserror = "2.0.17"
trybuild = "1.0.114"
unicode-ident = "1.0.22"
uuid = "1.16.0"

[workspace.lints.clippy]
needless_pass_by_value = "warn"
3 changes: 3 additions & 0 deletions cargo-typify/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,6 @@ assert_cmd = { workspace = true }
expectorate = { workspace = true }
newline-converter = { workspace = true }
tempdir = { workspace = true }

[lints]
workspace = true
2 changes: 1 addition & 1 deletion cargo-typify/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ pub fn convert(args: &CliArgs) -> Result<String> {
rename,
} in &args.crates
{
settings.with_crate(name, version.clone(), rename.as_ref());
settings.with_crate(name, version.clone(), rename.clone());
}

if let Some(map_type) = &args.map_type {
Expand Down
3 changes: 3 additions & 0 deletions example-build/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,6 @@ schemars = "0.8"
serde_json = "1.0"
syn = "2.0"
typify = { path = "../typify" }

[lints]
workspace = true
3 changes: 3 additions & 0 deletions example-macro/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,6 @@ edition = "2021"
typify = { path = "../typify" }
serde = "1.0"
serde_json = "1.0"

[lints]
workspace = true
3 changes: 3 additions & 0 deletions typify-impl/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,6 @@ schema = { workspace = true }
schemars = { workspace = true, features = ["uuid1", "impl_json_schema"] }
syn = { workspace = true, features = ["full", "extra-traits", "visit-mut"] }
uuid = { workspace = true }

[lints]
workspace = true
Loading