Merged
Conversation
+ can now download LRT test table and fragment length distribution plot + this partially addresses pachterlab#62 (only one missing is multi-transcript gene view when gene_mode is FALSE)
…iles + This should make it clear to users when issue uncovered in pachterlab#120 might apply
…ipts = FALSE + this fixes error found in pachterlab#208
…f cluster_transcripts is FALSE + this fixes the bug identified in pachterlab#207
|
Any chance to get this merged and a new release? The heatmap bug can lead to severe misinterpretations if people faithfully try to replace the row labels. |
pimentel
approved these changes
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @pimentel and @lynnyi,
I have completed the to-do list I created in #213, but figured I should open a separate pull request to incorporate them all. There might be an issue with my shiny changes (6ff28d2 and
193745f), but otherwise, everything else should be solid.
Here is a list of issues that have been addressed:
utils::headplot_cluster_heatmapbugs found in Order of labels_row in plot_transcript_heatmap #207 and cluster_transcripts = FALSE still cluster rows in plot_transcript_heatmap #208.%needs to be escaped)