fix double-negation in gene_column check upon manual change of pval_aggregate in sleuth_object#240
Open
dlaehnemann wants to merge 1 commit intopachterlab:masterfrom
Open
Conversation
…ggregate in sleuth_object
Author
|
Just a quick ping @warrenmcg @pimentel, in case this PR slipped by. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changed code would previously stop with an error, if you assigned the value
TRUEtopval_aggregatein a sleuth object with thegene_columndefined, contrary to the error message given. @AntonieV and I stumbled upon this, and believe this is merely an unintended double-negation in theif-clause.