fix(complexity): add catch_clause to flat types + research citations #303
+182
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per SonarSource spec, catch/except clauses should be flat constructs (+1 only, no nesting penalty). Added catch_clause and except_clause to flat node types. Also adds research citations to 9 analyzers: - complexity.rs: McCabe 1976, SonarSource spec - hotspot.rs: Tornhill 2015, threshold derivation - temporal.rs: Ball et al. 1997 - ownership.rs: Bird et al. 2011, Avelino et al. 2016 - graph.rs: Page 1999, Brandes 2001, Martin 2003, Tarjan 1972 - cohesion.rs: Chidamber & Kemerer 1994, Hitz & Montazeri 1995 - duplicates.rs: Broder 1997, Indyk & Motwani 1998 - churn.rs: Nagappan & Ball 2005 (documents 0.6/0.4 as heuristics) - changes.rs: Kamei et al. 2013 (documents 6 missing features) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
catch_clauseandexcept_clauseto cognitive complexity flat types per SonarSource spec (catch should add +1 only, no nesting penalty)Changes
Bug Fix (complexity.rs, queries.rs)
Per SonarSource cognitive complexity specification,
catch/exceptclauses should be "flat" constructs (add +1 but no nesting increment), similar toelseclauses. This was missing from the implementation.Research Citations Added
Test plan
Generated with Claude Code