feat: update the default protocolFee for dynamic fee pool to 3bps #243
+163
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefMist
reviewed
Jun 23, 2025
src/ProtocolFeeController.sol
Outdated
| /// @notice the default protocol fee for dynamic fee pool, | ||
| /// every newly created dynamic fee pool will have this default protocol fee | ||
| /// @dev 1000 = 0.1%, the initial setting is 0.3% i.e. 3bps | ||
| uint24 public defaultProtocolFeeForDynamicFeePool = 3000; |
Contributor
There was a problem hiding this comment.
default is 0.3% or 0.03%?
Collaborator
Author
There was a problem hiding this comment.
ah, should be 0.03%. Updated, thx
chefburger
force-pushed
the
feat/update-protocolfeeController
branch
from
885790b to
c52d52f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR changes how the protocolFeeController contract works to update the default protocolFee for any future dynamic fee pools to 3bps
Next Step