-
Notifications
You must be signed in to change notification settings - Fork 12
Implement Glicko Model and Tests #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JamesVanBoxtel
wants to merge
5
commits into
panel-attack:beta
Choose a base branch
from
JamesVanBoxtel:glicko
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,342 @@ | ||
| -- Credit to "SpaceCube" for implementing the lua implementations | ||
| -- https://devforum.roblox.com/t/a-lua-implementation-of-the-glicko-2-rating-algorithm-for-skill-based-matchmaking/1442673 | ||
| -- 1 small bug fix is included: to1:() returned the wrong version | ||
|
|
||
| local util = require("common.lib.util") | ||
|
|
||
| --http://www.glicko.net/glicko/glicko2.pdf | ||
| local c = 173.7178 -- Used for conversion between Glicko1 and 2, not to be confused with c from Glicko1 | ||
| local epsilon = 1e-6 -- Convergence | ||
|
|
||
| -- Shortcuts for commonly used math functions | ||
| local exp = math.exp | ||
| local sqrt = math.sqrt | ||
| local log = math.log | ||
|
|
||
| -- Glicko2 | ||
| local Glicko2 = { | ||
| Tau = 0.5, -- Slider for volatility Smaller values prevent the volatility measures from changing by large | ||
| -- amounts, which in turn prevent enormous changes in ratings based on very improbable results. | ||
| InitialVolatility = 0.06 | ||
| }; Glicko2.__index = Glicko2 | ||
|
|
||
| -- Creates a Glicko rating with a specified version | ||
| function Glicko2.gv(Rating, RatingDeviation, Volatility, Version) | ||
| local self = { | ||
| Rating = Rating, | ||
| RD = RatingDeviation, | ||
| Vol = Volatility or Glicko2.InitialVolatility, | ||
| Version = Version or 2, | ||
| } | ||
|
|
||
| return setmetatable(self, Glicko2) | ||
| end | ||
|
|
||
| -- Creates a Glicko1 rating | ||
| function Glicko2.g1(Rating, RatingDeviation, Volatility) | ||
| return Glicko2.gv( | ||
| Rating or 1500, | ||
| RatingDeviation or 350, | ||
| Volatility, | ||
| 1 | ||
| ) | ||
| end | ||
|
|
||
| -- Creates a Glicko2 rating | ||
| function Glicko2.g2(Rating, RatingDeviation, Volatility) | ||
| return Glicko2.gv( | ||
| Rating or 0, | ||
| RatingDeviation or (350/c), | ||
| Volatility, | ||
| 2 | ||
| ) | ||
| end | ||
|
|
||
| function Glicko2:copy() | ||
| return Glicko2.gv(self.Rating, self.RD, self.Vol, self.Version) | ||
| end | ||
|
|
||
| -- Scales glicko rating to Glicko2 | ||
| function Glicko2:to2() | ||
| if self.Version == 2 then | ||
| return self:copy() | ||
| end | ||
|
|
||
| local g2 = Glicko2.g2((self.Rating - 1500)/c, self.RD/c, self.Vol) | ||
|
|
||
| if self.Score then | ||
| g2.Score = self.Score | ||
| end | ||
|
|
||
| return g2 | ||
| end | ||
|
|
||
| -- Scales glicko rating to Glicko1 | ||
| function Glicko2:to1() | ||
| if self.Version == 1 then | ||
| return self:copy() | ||
| end | ||
|
|
||
| local g1 = Glicko2.g1(self.Rating*c + 1500, self.RD*c, self.Vol) | ||
|
|
||
| if self.Score then | ||
| g1.Score = self.Score | ||
| end | ||
|
|
||
| return g1 | ||
| end | ||
|
|
||
| function Glicko2.serialize(gv) | ||
| return { | ||
| gv.Rating, | ||
| gv.RD, | ||
| gv.Vol, | ||
| gv.Score | ||
| } | ||
| end | ||
|
|
||
| function Glicko2.deserialize(gv_s, version) | ||
| local constructor = nil | ||
|
|
||
| -- Finds glicko constructor for specified version | ||
| if version == 1 then | ||
| constructor = Glicko2.g1 | ||
| elseif version == 2 then | ||
| constructor = Glicko2.g2 | ||
| else | ||
| error("Version must be specified for deserialization", 2) | ||
| end | ||
|
|
||
| local gv = constructor(gv_s[1], gv_s[2], gv_s[3]) | ||
|
|
||
| -- Inserts a score if there is one | ||
| if gv_s[4] then | ||
| gv = gv:score(gv_s[4]) | ||
| end | ||
|
|
||
| return gv | ||
| end | ||
|
|
||
| function Glicko2.updatedRatings(player1, player2, matchOutcomes, elapsedRatingPeriods) | ||
|
|
||
| local player1Results = {} | ||
| local player2Results = {} | ||
| for i = 1, #matchOutcomes do | ||
| local matchOutcome = matchOutcomes[i] | ||
| player1Results[#player1Results+1] = player2:score(matchOutcome) | ||
| if matchOutcome == 0 then | ||
| matchOutcome = 1 | ||
| elseif matchOutcome == 1 then | ||
| matchOutcome = 0 | ||
| end | ||
| player2Results[#player2Results+1] = player1:score(matchOutcome) | ||
| end | ||
|
|
||
| local updatedPlayer1 = player1:update(player1Results, elapsedRatingPeriods) | ||
| local updatedPlayer2 = player2:update(player2Results, elapsedRatingPeriods) | ||
|
|
||
| return updatedPlayer1, updatedPlayer2 | ||
| end | ||
|
|
||
| -- Attaches a score to an opponent | ||
| function Glicko2:score(score) | ||
| local new_g2 = self:copy() | ||
|
|
||
| --lost: 0, win: 1, tie: 0.5 | ||
| new_g2.Score = score or 0 | ||
|
|
||
| return new_g2 | ||
| end | ||
|
|
||
| -- Function g as described in step 3 | ||
| local function g(RD) | ||
| return 1/sqrt(1 + 3*RD^2/math.pi^2) | ||
| end | ||
|
|
||
| -- Function E as described in step 3 | ||
| local function E(rating, opRating, opRD) | ||
| return 1/(1 + exp(-g(opRD)*(rating - opRating))) | ||
| end | ||
|
|
||
| -- Constructor for function f described in step 5 | ||
| local function makebigf(g2, v, delta) | ||
| local a = log(g2.Vol^2) | ||
|
|
||
| return function(x) | ||
| local numer = exp(x)*(delta^2 - g2.RD^2 - v - exp(x)) --numerator | ||
| local denom = 2*(g2.RD^2 + v + exp(x))^2 --denominator | ||
| local endTerm = (x - a)/(Glicko2.Tau^2) --final term | ||
|
|
||
| return numer/denom - endTerm | ||
| end | ||
| end | ||
|
|
||
| -- Updates a Glicko rating using the last set of matches | ||
| function Glicko2:update(matches, elapsedRatingPeriods) | ||
| local g2 = self | ||
| local originalVersion = g2.Version | ||
|
|
||
| -- convert ratings to glicko2 | ||
| if originalVersion == 1 then | ||
| g2 = g2:to2() | ||
| end | ||
|
|
||
| local convertedMatches = {} | ||
| for i, match in ipairs(matches) do | ||
| if match.Version == 1 then | ||
| convertedMatches[i] = match:to2() | ||
| end | ||
| end | ||
|
|
||
| -- step 3: compute v | ||
| local v = 0 | ||
|
|
||
| for j, match in ipairs(convertedMatches) do | ||
| local EValue = E(g2.Rating, match.Rating, match.RD) | ||
|
|
||
| v = v + g(match.RD)^2*EValue*(1 - EValue) | ||
| end | ||
|
|
||
| v = 1/v | ||
|
|
||
| -- step 4: compute delta | ||
| local delta = 0 | ||
|
|
||
| for j, match in ipairs(convertedMatches) do | ||
| local EValue = E(g2.Rating, match.Rating, match.RD) | ||
|
|
||
| delta = delta + g(match.RD)*(match.Score - EValue) | ||
| end | ||
|
|
||
| delta = delta*v | ||
|
|
||
| -- step 5: find new volatility (iterative process) | ||
| local a = log(g2.Vol^2) | ||
|
|
||
| local bigf = makebigf(g2, v, delta) | ||
|
|
||
| -- step 5.2: find initial A and B values | ||
| local A = a | ||
| local B = 0 | ||
|
|
||
| if delta^2 > g2.RD^2 + v then | ||
| B = log(delta^2 - g2.RD^2 - v) | ||
| else | ||
| --iterative process for solving B | ||
| local k = 1 | ||
|
|
||
| while bigf(a - k*Glicko2.Tau) < 0 do | ||
| k = k + 1 | ||
| end | ||
|
|
||
| B = a - k*Glicko2.Tau | ||
| end | ||
|
|
||
| -- step 5.3: compute values of bigf of A and B | ||
| local fA = bigf(A) | ||
| local fB = bigf(B) | ||
|
|
||
| -- step 5.4: iterates until A and B converge | ||
| while math.abs(B - A) > epsilon do | ||
| local C = A + (A - B)*fA/(fB - fA) | ||
| local fC = bigf(C) | ||
|
|
||
| if fC*fB <= 0 then | ||
| A = B | ||
| fA = fB | ||
| else | ||
| fA = fA/2 | ||
| end | ||
|
|
||
| B = C | ||
| fB = fC | ||
| end | ||
|
|
||
| -- step 5.5: set new volatility | ||
| local newVol = g2.Vol | ||
|
|
||
| if #convertedMatches > 0 then | ||
| newVol = exp(A/2) | ||
| end | ||
|
|
||
| -- step 6: update the rating deviation to the new pre-rating period value | ||
| local ratingDeviation = self:calculateNewRD(g2.RD, newVol, elapsedRatingPeriods) | ||
|
|
||
| -- Step 7: Update to the new rating | ||
|
|
||
| local newRD = 1/sqrt(1/ratingDeviation^2 + 1/v) | ||
| local newRating = g2.Rating | ||
|
|
||
| if #convertedMatches > 0 then | ||
| local accumulation = 0 | ||
| for j, match in ipairs(convertedMatches) do | ||
| local EValue = E(g2.Rating, match.Rating, match.RD) | ||
| accumulation = accumulation + g(match.RD)*(match.Score - EValue) | ||
| end | ||
|
|
||
| newRating = g2.Rating + newRD^2*accumulation | ||
| end | ||
|
|
||
| --wrap up results | ||
| local result = Glicko2.g2(newRating, newRD, newVol) | ||
|
|
||
| if originalVersion == 1 then | ||
| result = result:to1() | ||
| end | ||
|
|
||
| return result | ||
| end | ||
|
|
||
| -- This is the formula defined in step 6. It is also used for players who have not competed during the rating period | ||
| function Glicko2:calculateNewRD(ratingDeviation, volatility, elapsedRatingPeriods) | ||
| local ratingDeviation = sqrt(ratingDeviation^2 + elapsedRatingPeriods * volatility^2) | ||
| return ratingDeviation | ||
| end | ||
|
|
||
| function Glicko2:deviation(deviations) | ||
| deviations = deviations or 2 | ||
| local radius = self.RD*deviations | ||
|
|
||
| return self.Rating - radius, self.Rating + radius | ||
| end | ||
|
|
||
| function Glicko2:expectedOutcome(otherGlicko) | ||
| local g2 = self | ||
| local otherGlicko2 = otherGlicko | ||
|
|
||
| -- convert ratings to glicko2 | ||
| if g2.Version == 1 then | ||
| g2 = g2:to2() | ||
| end | ||
| if otherGlicko2.Version == 1 then | ||
| otherGlicko2 = otherGlicko2:to2() | ||
| end | ||
|
|
||
| local function A(glicko1, glicko2) | ||
| return g(sqrt(glicko1.RD^2+glicko2.RD^2)) * (glicko2.Rating-glicko1.Rating) | ||
| end | ||
|
|
||
| local function myFunc(glicko1, glicko2) | ||
| return 1/(1 + exp(-A(glicko1, glicko2))) | ||
| end | ||
|
|
||
| local result = myFunc(otherGlicko2, g2) | ||
| return result | ||
| end | ||
|
|
||
| function Glicko2:range(padding) | ||
| padding = padding or 0 | ||
| local small, big = self:deviation() | ||
|
|
||
| return small - padding, big + padding | ||
| end | ||
|
|
||
| function Glicko2:percent(confidence) | ||
| confidence = util.bound(0, confidence, 1) | ||
| assert(confidence < 1, "Percentage cannot be equal or greater than 1") | ||
|
|
||
| --This is a simple inverse erf approximation, has accuracy of +- 0.02 | ||
| return self:deviation(.5877*math.log((1 + confidence)/(1 - confidence))) | ||
| end | ||
|
|
||
| return Glicko2 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example ranking you generated shows players with an RD below 30.
In the paper on Glicko it is stated that
For the Panel Attack ladder I believe this to be highly relevant with a small number of players that always keep ranked on driving their RD low compared to everyone playing ranked only on a weekly or monthly basis.