Merged
Conversation
…sWithSwapCount field
…ide of validity tests
adapt stopWatchIsRunning for SimulatedStack remove obsolete check for countdown in checkMatches
…st that simulates live desync change signatures of rollback related functions to clearly indicate whether they are operating on clock or stopWatch enable forced desync in matches with a dedicated function and remove its reference to the client's global config
JamesVanBoxtel
approved these changes
Nov 22, 2025
Contributor
JamesVanBoxtel
left a comment
JamesVanBoxtel
left a comment
There was a problem hiding this comment.
Fixed a crash and added test
Tests well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some old commits that applied review feedback that were not merged in somehow.
It mainly consists of readability changes to clarify whether a component is dealing with clock time or stopWatch time for its functionality.
But also some puzzle related readability changes.
It does also fix a bug in which rollback would either rollback further than necessary or fail due to not finding the needed rollback copy - the new function
Match:rollbackToStopWatchserves to calculate the delta between clock and stopWatch. Rollback on match level always rolls back the clock. But some components only run on stopWatch now so a stack will roll them back to the stopWatch it has after its own part of the rollback.