-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add lightbox overlay for postcard preview #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Click on postcard preview to open in lightbox modal - Added close button to dismiss the lightbox - Displays larger version of postcard with flipping functionality - Reuses existing Modal component from ui package Fixes #42 Co-authored-by: Marco Wettstein <macrozone@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@claude nothing happens if i click on the preview. what is wrong? |
|
Claude finished @macrozone's task —— View job Fixed the lightbox issue ✅Tasks:
Issue Found and FixedThe problem was in the click handler condition on line 183 of Fixed by: Removing the incorrect - if (!draggingOverlay && !onOverlayUpdate) {
+ if (!draggingOverlay) {
setShowLightbox(true);
}The lightbox should now work correctly when you click on the postcard preview! 🎉 Branch: claude/issue-42-20250927-1250 |
The lightbox was not opening when onOverlayUpdate prop was provided. Removed the incorrect !onOverlayUpdate check from the click handler. Co-authored-by: Marco Wettstein <macrozone@users.noreply.github.com>
|
@claude looks better. however, the variant selections of the images seem to have a larger z-index and are above the overlay. consider using portal as well |
|
Claude finished @macrozone's task —— View job Fixed the z-index issue with variant selections ✅Tasks:
Solution ImplementedUpdated the Modal component to use React Portal:
This ensures the lightbox modal will always appear above any other page elements, including variant selections that may have high z-index values. The portal approach is the proper solution for modals as it removes the component from the normal DOM hierarchy, preventing any z-index stacking context issues. Branch: claude/issue-42-20250927-1250 |
The Modal component now uses createPortal to render at the document body level, ensuring it appears above all other page elements including variant selections. Also increased z-index to 9999 for maximum visibility. Co-authored-by: Marco Wettstein <macrozone@users.noreply.github.com>
Closes #42
Summary
Implemented a lightbox overlay feature for the postcard preview component. When users click on the postcard preview, it now opens in a modal lightbox with a larger view.
Changes
Testing
The lightbox opens when clicking on the postcard preview and can be closed using the close button or by clicking outside the modal.
Generated with Claude Code