feat(workflows): Implement modular workflows app architecture #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create NX app structure in apps/workflows/ with esbuild bundler - Refactor monolithic check-repo-settings script into modular components - Split 294-line script into 8 focused modules with single responsibilities - Implement comprehensive test suite with 29 tests using Bun test runner - Add JSDoc documentation to all public APIs following TSDoc conventions - Convert named functions to arrow functions per ESLint prefer-arrow rule - Update CI/CD workflow to use compiled output from workflows app - Remove legacy .github/scripts/check-repo-settings.ts - Update root README with workflows app documentation Architecture: - apps/workflows/src/scripts/check-repo-settings/ - Modular business logic - apps/workflows/src/utils/ - Shared utilities (retry, github-summary) - Strict TypeScript mode with full type safety - Zero lint/type errors, 100% test coverage of business logic See apps/workflows/README.md for complete documentation.
thoroc
force-pushed
the
feat/workflows-app-architecture
branch
from
f604e0e to
ee488d7
Compare
|
This PR is quite large with:
Consider breaking it down into smaller, focused PRs for easier review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the modular workflows app architecture by refactoring monolithic CI/CD scripts into a testable, maintainable NX application.
Changes
Created NX App Structure (
apps/workflows/)Refactored Check Repo Settings Script
Modular Architecture
apps/workflows/src/scripts/check-repo-settings/- Business logicapps/workflows/src/utils/- Shared utilities (retry, github-summary)CI/CD Updates
.github/workflows/check-repo-settings.ymlto use compiled output.github/scripts/check-repo-settings.tsTesting
All validation passing:
Documentation
apps/workflows/README.md- Comprehensive architecture guideREADME.md- Updated with workflows app section