Skip to content

Fix issues on mobile/touch devices #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alex-spataru wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix issues on mobile/touch devices #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e6012d
Fix issues on mobile/touch devices
alex-spataru Nov 2, 2015
696fdbf
Fit window to screen in mobile devices
alex-spataru Nov 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions modules/Material/ApplicationWindow.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,11 @@ Controls.ApplicationWindow {
id: overlayLayer
}

width: Units.dp(800)
height: Units.dp(600)
// Trust me, this is for the greater good
// The behavior on the desktop will remain unmodified, while
// the application will be resized automatically on mobile devices
width: 0
height: 0

Dialog {
id: errorDialog
Expand Down Expand Up @@ -202,5 +205,16 @@ Controls.ApplicationWindow {
return Device.type === Device.phone || Device.type === Device.phablet
? Units.dp(48) : Device.type == Device.tablet ? Units.dp(56) : Units.dp(64)
})

// Show the application maximized on a mobile device, the window will be resized automatically.
// On the desktop devices, everything will work exactly as it did before
if (Device.isMobile) {
showMaximized()
} else {
width = Units.dp (800)
height = Units.dp (600)

showNormal()
}
}
}
2 changes: 1 addition & 1 deletion modules/Material/Ink.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ MouseArea {
id: view

clip: true
hoverEnabled: enabled
hoverEnabled: !Device.isMobile
z: 2

property int startRadius: circular ? width/10 : width/6
Expand Down