introduce max message size in webrtc config #442
Conversation
…mi/buffer-size-webrtc-config # Conflicts: # src/transport/webrtc/opening.rs
src/transport/webrtc/config.rs
Outdated
| .parse() | ||
| .expect("valid multiaddress")], | ||
| datagram_buffer_size: 2048, | ||
| max_message_size: 512 * 1024, |
There was a problem hiding this comment.
Where this constant is coming from? What is libp2p way of handling this?
What will happen in case of high throughput transfer — shouldn't we be able to parse the payload split over multiple max_message_size buffers?
There was a problem hiding this comment.
Maybe we should make this optional, not entirely sure if this interferes with @timwu20 upcoming work 🤔
There was a problem hiding this comment.
I would suggest hardcoding the constant from libp2p spec, as discussed in #352.
There was a problem hiding this comment.
Oki doki makes sense 🙏 Let's hardcode it instead
There was a problem hiding this comment.
so, @lexnv should i remove the max_message_size entirely from the config?
There was a problem hiding this comment.
Hey yep, let's pick: #352 (comment) 16kIB for this
3 participants
closes #352