Skip to content
This repository was archived by the owner on Sep 22, 2021. It is now read-only.

Comments

Switching LRU mode in redis for keys eviction on max memory usage#1007

Open
niklabh wants to merge 2 commits intomasterfrom
niklabh-redis-memory
Open

Switching LRU mode in redis for keys eviction on max memory usage#1007
niklabh wants to merge 2 commits intomasterfrom
niklabh-redis-memory

Conversation

@niklabh
Copy link
Contributor

@niklabh niklabh commented Aug 28, 2020

Closes: #600

As per https://redis.io/topics/lru-cache setting --maxmemory-policy will evict keys when full memory


master:
extraFlags:
- --maxmemory-policy allkeys-lru
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think "" are required her: like in

  extraFlags:
    - "--maxmemory-policy allkeys-lru"
``


master:
extraFlags:
- --maxmemory-policy allkeys-lru
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think "" are required her: like in

  extraFlags:
    - "--maxmemory-policy allkeys-lru"
``

@Tbaut
Copy link
Contributor

Tbaut commented Sep 1, 2020

The original issue #600 suggests to use Redis because we don't for address linking
https://github.com/paritytech/polkassembly/blob/master/auth-server/src/resolvers/mutation/addressLinkStart.ts#L31-L40

This PR is probably good as a fail safe, but it doesn't solve the original problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use redis for address linking token

3 participants