Physoc Website 2023 Summer Update 1.1#1
Open
aoneillmark wants to merge 56 commits intoparkerro-dev:masterfrom
Open
Physoc Website 2023 Summer Update 1.1#1aoneillmark wants to merge 56 commits intoparkerro-dev:masterfrom
aoneillmark wants to merge 56 commits intoparkerro-dev:masterfrom
Conversation
Home About Gallery Contact Us Added a footer with social media links as well as a 'back to top' button. Home: Scrolling images and general information about the society. About: Essentially a 'meet the committee' page. Need to add some more info about the society, its history etc. Contact us: Included an email (physical@csc.tcd.ie) as well as mailing address. Gallery: A page with a Gallery of images from events and brief descriptions of the events. Easily editable. The Library page is still under construction, and the Join is just a link to the trinity society signups page. Removed herobrine etc
Author
|
Fixed everything, should be rocking and ready to go |
Added lazy loading in gallery page
This reverts commit 200dfb2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added pages: Home, About, Gallery, Contact us
Added Join button linking to trinitysocieties page
Added Library page as a placeholder
Updated footer to include icons and links to instagram, discord, and possibly future linkedin page, also added a "back to top" button.
Home: Sliding image carousel and description for what the society is
About: essentially a 'meet the committee' page, could be updated to include more society history (established circa 1975 etc), also could include links to mathsoc, scisoc and tpsa pages, as well as tcd physics site.
Gallery: Includes a bunch of images of events with descriptions, can be easily updated and added to in the Gallery_Images_directories.js file.
Contact us: Included contact email and mail address
Fixed logo so that it's centred :)