Html assignment by parthshah51999 · Pull Request #1 · parthshah51999/Html_Assignment

parthshah51999 · 2019-06-30T13:45:34Z

No description provided.

Karanpharate · 2019-06-30T14:46:03Z

assignment.html

+  </head>
  <body>
-    <div id="app"></div>
+    <div class="mainNav">


div not needed.add class to ul

rishabhtatia1 · 2019-06-30T14:46:25Z

assignment.html

+    </div>
+    <div class="bodywrapper">
+      <h1>How It Works</h1>
+      <div class="circle">


remove this div

Karanpharate · 2019-06-30T14:46:32Z

assignment.html

-    <title>React App</title>
-      </head>
+    <title>Assignment 1</title>
+    <link rel="stylesheet" type="text/css" href="style.css"/>


remove type attribute

rishabhtatia1 · 2019-06-30T14:47:16Z

assignment.html

+      <h1>How It Works</h1>
+      <div class="circle">
+        <ul>
+          <li id="firstTile"><div></div><p>Add art to your queue <br> online</p></li>


use float left
remove br tag
add width to paragraph

rishabhtatia1 · 2019-06-30T14:47:53Z

style.css

+}
+
+.bodywrapper .circle li {
+  display: inline-block;


rishabhtatia1 · 2019-06-30T14:48:15Z

style.css

+}
+
+.footerList {
+  height: 50px;


do not use height use padding

rishabhtatia1 · 2019-06-30T14:48:36Z

style.css

+}
+
+.footerList li {
+  display: inline;


use float
remove line height

rishabhtatia1 · 2019-06-30T14:49:06Z

style.css

+  color: #444444;
+}
+
+#firstTile {


remove this css

rishabhtatia1 · 2019-06-30T14:49:33Z

assignment.html

+      <h1>How It Works</h1>
+      <div class="circle">
+        <ul>
+          <li id="firstTile"><div></div><p>Add art to your queue <br> online</p></li>


rishabhtatia1 · 2019-06-30T14:51:06Z

style.css

+* {
+  margin: 0;
+  padding: 0;
+  box-sizing: border-box;


remove box-sizing

rishabhtatia1 · 2019-06-30T14:51:40Z

style.css

+}
+
+.mainNav li {
+  display: inline;


remove inline

rishabhtatia1 · 2019-06-30T14:52:20Z

style.css

+  border-radius: 50%;
+  background-color: #efefef;
+  margin-top: 70px;
+  display: inline-block;


remove inline-block

Karanpharate · 2019-06-30T14:55:00Z

style.css

+.mainNav li {
+  display: inline;
+  color: #aaaaaa;
+  padding: 25px;


use margin top and bottom 17px

Karanpharate · 2019-06-30T14:55:03Z

style.css

+}
+
+.banner {
+  height: 100px;


use padding for height

Karanpharate · 2019-06-30T14:55:39Z

style.css

+
+.banner {
+  height: 100px;
+  width: 100%;


width not required.

Karanpharate · 2019-06-30T15:00:46Z

style.css

+
+.footerList {
+  height: 50px;
+  background-color: #ECECEC;


use small letters for color;

Karanpharate · 2019-06-30T15:01:48Z

assignment.html

+      <h1>How It Works</h1>
+      <div class="circle">
+        <ul>
+          <li id="firstTile"><div></div><p>Add art to your queue <br> online</p></li>


avoid use of br tag

Karanpharate

use html and css formatter and validators
https://validator.w3.org/
https://www.freeformatter.com/html-formatter.html

Karanpharate · 2019-06-30T15:07:28Z

style.css

+  display: inline;
+  vertical-align: middle;
+  line-height: 55px;
+  padding: 10px;


use margin instead

parthshah51999 added 3 commits June 29, 2019 17:03

Initial html elements

35c872a

Initial styling

78e2f0c

CSS modifications

2f11a3f

parthshah51999 requested a review from visha12l June 30, 2019 13:45

parthshah51999 self-assigned this Jun 30, 2019

Karanpharate reviewed Jun 30, 2019

View reviewed changes

assignment.html Outdated

</head>

<body>

<div id="app"></div>

<div class="mainNav">

Copy link

Collaborator

Karanpharate Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

div not needed.add class to ul

rishabhtatia1 reviewed Jun 30, 2019

View reviewed changes

assignment.html

</div>

<div class="bodywrapper">

<h1>How It Works</h1>

<div class="circle">

Copy link

Collaborator

rishabhtatia1 Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this div

Karanpharate reviewed Jun 30, 2019

View reviewed changes

rishabhtatia1 reviewed Jun 30, 2019

View reviewed changes

style.css Outdated

}

.bodywrapper .circle li {

display: inline-block;

Copy link

Collaborator

rishabhtatia1 Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use float

rishabhtatia1 reviewed Jun 30, 2019

View reviewed changes

style.css Outdated

}

.footerList {

height: 50px;

Copy link

Collaborator

rishabhtatia1 Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not use height use padding

rishabhtatia1 reviewed Jun 30, 2019

View reviewed changes

style.css Outdated

}

.footerList li {

display: inline;

Copy link

Collaborator

rishabhtatia1 Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use float
remove line height

rishabhtatia1 reviewed Jun 30, 2019

View reviewed changes

style.css Outdated

color: #444444;

}

#firstTile {

Copy link

Collaborator

rishabhtatia1 Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this css

rishabhtatia1 reviewed Jun 30, 2019

View reviewed changes

style.css Outdated

* {

margin: 0;

padding: 0;

box-sizing: border-box;

Copy link

Collaborator

rishabhtatia1 Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove box-sizing

rishabhtatia1 reviewed Jun 30, 2019

View reviewed changes

style.css Outdated

}

.mainNav li {

display: inline;

Copy link

Collaborator

rishabhtatia1 Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove inline

rishabhtatia1 reviewed Jun 30, 2019

View reviewed changes

Karanpharate reviewed Jun 30, 2019

View reviewed changes

style.css Outdated

.mainNav li {

display: inline;

color: #aaaaaa;

padding: 25px;

Copy link

Collaborator

Karanpharate Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use margin top and bottom 17px

Karanpharate reviewed Jun 30, 2019

View reviewed changes

style.css Outdated

}

.banner {

height: 100px;

Copy link

Collaborator

Karanpharate Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use padding for height

Karanpharate reviewed Jun 30, 2019

View reviewed changes

style.css

.banner {

height: 100px;

width: 100%;

Copy link

Collaborator

Karanpharate Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

width not required.

Karanpharate reviewed Jun 30, 2019

View reviewed changes

style.css

.footerList {

height: 50px;

background-color: #ECECEC;

Copy link

Collaborator

Karanpharate Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use small letters for color;

Karanpharate reviewed Jun 30, 2019

View reviewed changes

Karanpharate requested changes Jun 30, 2019

View reviewed changes

Karanpharate reviewed Jun 30, 2019

View reviewed changes

style.css Outdated

display: inline;

vertical-align: middle;

line-height: 55px;

padding: 10px;

Copy link

Collaborator

Karanpharate Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use margin instead

parthshah51999 added 2 commits July 3, 2019 13:53

corrections

6013da9

corrections for height and padding

a02b26e

Comments

Conversation

parthshah51999 commented Jun 30, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Karanpharate Jun 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Karanpharate left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Karanpharate Jun 30, 2019 •

edited

Loading