Move the addition of reflection log classes to Options.postProcess
#213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the need for adding classes from the reflection log to the closed-world for different frontends in a uniform way, by making 3 following changes:
Options.analysesis changed fromMap<String, String>toMap<String, AnalysisOptions>. This is because accessing reflection logs requiresAnalysisOptions, but they are not accessible until the processing ofOptionsis done. Moving the parsing logic ofAnalysisOptionsfromPlanConfigtoOptionsvia picocli converters simplifiesPlanConfigwhile makingOptionscohesive.SootWorldBuildertoOptions.postProcess. This leaves world builders now unaware of reflection and analyses.WorldBuilder.builddoes not need itsanalysesargument anymore, sinceAnalysisOptionscan be now accessed viaOptions. This simplifies the interface of all world builders.