Adding a preconditioner example#120
Open
vboussange wants to merge 2 commits intopatrick-kidger:mainfrom
Open
Conversation
Owner
|
In terms of the implementation, I like this example! It's short and easy to follow. (Nit: Also tagging @frederic-bender from #8, as I don't have strong feelings about what would make for a stronger example of preconditioning. (I note that the Julia folks also only consider a very simple example.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, here is an attempt to make an example for the use of a preconditioner, as discussed in #8. I implemented a simple Jacobi preconditioner, which does not seem to provide much advantage though. @patrick-kidger Any idea of a low hanging fruit solution to have a nicer demonstration of the use of preconditioners?
I personally would love to see an example with a hand crafted preconditioner such as the one proposed, and a more involved using e.g.
pyamgpreconditioning capability, with a possiblepure_callbackcall.