fix is_symmetric for complex PSD/NSD matrices#200
Open
jpbrodrick89 wants to merge 5 commits intopatrick-kidger:mainfrom
Open
fix is_symmetric for complex PSD/NSD matrices#200jpbrodrick89 wants to merge 5 commits intopatrick-kidger:mainfrom
jpbrodrick89 wants to merge 5 commits intopatrick-kidger:mainfrom
Conversation
…dentityLinearOperator to avoid test failures
Contributor
Author
|
Can confirm only one failing test now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, is_symmetric returns True for PSD/NSD matrices. This led to failing test in test_well_posed.py when we changed our transpose rules, this should be a minimal fix.
Note we could go all out and add
is_hermitiantests and.Hhelper function for less verbosity, but as I think we're not really prioritising complex support right now (e..g see comment in CG solver) that can be delayed for now.