Skip to content

No warnings #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BwanaFr wants to merge 3 commits into
base: master
Choose a base branch
from
Open

No warnings #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99ffb98
Fix some compilation warnings on ESP32 (IDF 5.1.0)
BwanaFr Oct 17, 2025
168f6f1
Fixed indentation
BwanaFr Oct 17, 2025
5fe75e5
Avoid static_cast in enums
BwanaFr Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 29 additions & 27 deletions src/BER.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,39 +286,39 @@ class Type: public Base {
*/
enum : uint16_t {
// Universal
Boolean = Class::Universal | Form::Primitive | 0x01, /**< 0x01 */
Integer, /**< 0x02 */
BitString, /**< 0x03 */
OctetString, /**< 0x04 */
Null, /**< 0x05 */
ObjectIdentifier, /**< 0x06 */
Sequence = Class::Universal | Form::Constructed | 0x10, /**< 0x30 */
Boolean = +Class::Universal | +Form::Primitive | 0x01, /**< 0x01 */
Integer, /**< 0x02 */
BitString, /**< 0x03 */
OctetString, /**< 0x04 */
Null, /**< 0x05 */
ObjectIdentifier, /**< 0x06 */
Sequence = +Class::Universal | +Form::Constructed | 0x10, /**< 0x30 */
// Application
IPAddress = Class::Application | 0x00, /**< 0x40 */
Counter32, /**< 0x41 */
Gauge32, /**< 0x42 */
TimeTicks, /**< 0x43 */
Opaque, /**< 0x44 */
Counter64 = Class::Application | 0x06, /**< 0x46 */
Float = Class::Application | 0x08, /**< 0x48 */
IPAddress = +Class::Application | 0x00, /**< 0x40 */
Counter32, /**< 0x41 */
Gauge32, /**< 0x42 */
TimeTicks, /**< 0x43 */
Opaque, /**< 0x44 */
Counter64 = +Class::Application | 0x06, /**< 0x46 */
Float = +Class::Application | 0x08, /**< 0x48 */
// Context
NoSuchObject = Class::Context | 0x00, /**< 0x80 */
NoSuchInstance, /**< 0x81 */
EndOfMIBView, /**< 0x82 */
NoSuchObject = +Class::Context | 0x00, /**< 0x80 */
NoSuchInstance, /**< 0x81 */
EndOfMIBView, /**< 0x82 */
// Version 1
GetRequest = Class::Context | Form::Constructed | 0x00, /**< 0xA0 */
GetNextRequest, /**< 0xA1 */
GetResponse, /**< 0xA2 */
SetRequest, /**< 0xA3 */
Trap, /**< 0xA4 */
GetRequest = +Class::Context | +Form::Constructed | 0x00, /**< 0xA0 */
GetNextRequest, /**< 0xA1 */
GetResponse, /**< 0xA2 */
SetRequest, /**< 0xA3 */
Trap, /**< 0xA4 */
// Version 2C
GetBulkRequest, /**< 0xA5 */
InformRequest, /**< 0xA6 */
SNMPv2Trap, /**< 0xA7 */
GetBulkRequest, /**< 0xA5 */
InformRequest, /**< 0xA6 */
SNMPv2Trap, /**< 0xA7 */
// Version 3
Report, /**< 0xA8 */
Report, /**< 0xA8 */
// Opaque type
OpaqueFloat = 0x9F78 /**< 0x9F78 */
OpaqueFloat = 0x9F78 /**< 0x9F78 */
};

/**
Expand Down Expand Up @@ -2642,3 +2642,5 @@ class OpaqueFloatBER: public FloatBER {
} // namespace SNMP

#endif /* BER_H_ */


16 changes: 8 additions & 8 deletions src/SNMPMessage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,16 +115,16 @@ class Message: public SequenceBER, private PDU {
*/
class OID {
public:
static constexpr char *COLDSTART = "1.3.6.1.6.3.1.1.5.1";
static constexpr char *WARMSTART = "1.3.6.1.6.3.1.1.5.2";
static constexpr char *LINKDOWN = "1.3.6.1.6.3.1.1.5.3";
static constexpr char *LINKUP = "1.3.6.1.6.3.1.1.5.4";
static constexpr char *AUTHENTICATIONFAILURE = "1.3.6.1.6.3.1.1.5.5";
static constexpr const char *COLDSTART = "1.3.6.1.6.3.1.1.5.1";
static constexpr const char *WARMSTART = "1.3.6.1.6.3.1.1.5.2";
static constexpr const char *LINKDOWN = "1.3.6.1.6.3.1.1.5.3";
static constexpr const char *LINKUP = "1.3.6.1.6.3.1.1.5.4";
static constexpr const char *AUTHENTICATIONFAILURE = "1.3.6.1.6.3.1.1.5.5";

private:
static constexpr char *SYSUPTIME = "1.3.6.1.2.1.1.3.0";
static constexpr char *SNMPTRAPOID = "1.3.6.1.6.3.1.1.4.1.0";
static constexpr char *SNMPTRAPENTERPRISE = "1.3.6.1.6.3.1.1.4.3.0";
static constexpr const char *SYSUPTIME = "1.3.6.1.2.1.1.3.0";
static constexpr const char *SNMPTRAPOID = "1.3.6.1.6.3.1.1.4.1.0";
static constexpr const char *SNMPTRAPENTERPRISE = "1.3.6.1.6.3.1.1.4.3.0";

friend class Message;
};
Expand Down