FIX: OCaml syntax highlighting - line directive#29
Open
cakedev0 wants to merge 9 commits intopatricoferris:mainfrom
Open
FIX: OCaml syntax highlighting - line directive#29cakedev0 wants to merge 9 commits intopatricoferris:mainfrom
cakedev0 wants to merge 9 commits intopatricoferris:mainfrom
Conversation
- Reorder pattern matching to check operators/literals before comments - Fix floating point regex to properly match complete decimal numbers like 6.28 Co-authored-by: cakedev0 <25986961+cakedev0@users.noreply.github.com>
Co-authored-by: cakedev0 <25986961+cakedev0@users.noreply.github.com>
cakedev0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23
Context: This issue is seriously damaging the readability of the manual. I was completely new to OCaml, and this generated a lot of perplexity, and it took me a while to understand it was a syntax highlighting bug. It was a fairly unpleasant first experience with the language.
How I did this PR: I iterated using Copilot. I vaguely understand the changes, and they feel right. I do understand the new test well, and it seems good.
Changes:
^[[:space:]]*(#)[[:space:]]*([[:digit:]]+)to^[[:space:]]*(#)[[:space:]]*([[:digit:]]+)[[:space:]]+\". This ensures it only matches actual line directives (like# 123 "file.ml"), not REPL prompts with numbers (like# 50 * 50)