Skip to content

Conversation

@andrew-ronaldson
Copy link
Contributor

Related to openshift/console#14925

The images used in the user feedback extension don't have a dark theme variant so this is a short-term solution for OCP.

@andrew-ronaldson andrew-ronaldson requested a review from dlabaj April 2, 2025 12:10
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the graphic continues off of the background on Firefox. do you think you could optimize the graphic by cutting parts off which aren't shown?

image

can we also minify the SVG?

https://jakearchibald.github.io/svgomg/

Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appears the light theme graphic isn't minified either

Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appears the light theme graphic isn't minified either

@logonoff logonoff merged commit a1ca426 into main Apr 2, 2025
4 checks passed
@logonoff logonoff deleted the dark-theme-img branch April 2, 2025 19:26
@github-actions
Copy link

🎉 This PR is included in version 6.2.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants