Skip to content

Conversation

@parthivrh
Copy link
Contributor

The commit message for the recent changes did not pass our commit message linter, which prevented the automated release. This PR uses a whitespace-only change to rectify this and initiate the release.

```

### Modal with internationalization support
To customize the content displayed in the feedback modal, pass in a custom `i18n` object with values for each property of`<FeedbackModal>`. This allows you to prepare a modal for different languages and requirements.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To customize the content displayed in the feedback modal, pass in a custom `i18n` object with values for each property of`<FeedbackModal>`. This allows you to prepare a modal for different languages and requirements.
To customize the content displayed in the feedback modal, pass in a custom `i18n` object with values for each property of `<FeedbackModal>`. This allows you to prepare a modal for different languages and requirements.

Just noticed there is a space missing here, so maybe this can be the whitespace change needed to trigger a release? Also I'm not sure if this repo uses semantic release messages, but if it does chore() will not initiate a release. fix() will issue a patch release (eg 1.2.3 -> 1.2.4) and feat() will issue a minor/feature release (eg 1.2.3 -> 1.3.0)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does use semantic release. Can you update the git commit to use fix: Other then @mcoker comment. lgtm. Thanks @parthivrh

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcoker @dlabaj this is one of the repos where I have some custom release rules in the semantic release config file so chore(ci-release) should issue a patch release.

This is semantic-release though so anything is possible.

Copy link

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wise-king-sullyman wise-king-sullyman merged commit 9c069ce into patternfly:main May 22, 2025
4 checks passed
@github-actions
Copy link

🎉 This PR is included in version 6.2.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 6.2.0-prerelease.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants