Skip to content

Passing block to the asssistant initializer #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mengqing wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Passing block to the asssistant initializer #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/langchainrb_overrides/assistant.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ class Assistant

alias_method :original_initialize, :initialize

def initialize(id: nil, **kwargs) # rubocop:disable Style/ArgumentsForwarding
def initialize(id: nil, **kwargs, &block) # rubocop:disable Style/ArgumentsForwarding
@id = id
original_initialize(**kwargs) # rubocop:disable Style/ArgumentsForwarding
original_initialize(**kwargs, &block) # rubocop:disable Style/ArgumentsForwarding
end

def save
Expand Down
10 changes: 9 additions & 1 deletion spec/langchainrb_overrides/assistant_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,12 @@ def update!(*)
end

RSpec.describe Langchain::Assistant do
let(:test_block) { proc { "test block executed" } }
let(:tools) { [] }
let(:llm) { Langchain::LLM::GoogleGemini.new(api_key: "123") }
let(:assistant) { described_class.new(llm: llm, id: nil, tools: tools, instructions: "Test instructions", tool_choice: "auto") }
let(:assistant) do
described_class.new(llm: llm, id: nil, tools: tools, instructions: "Test instructions", tool_choice: "auto", &test_block)
end

describe "#initialize" do
it "sets the id and calls original_initialize" do
Expand All @@ -55,6 +58,11 @@ def update!(*)
expect(assistant.instructions).to eq("Test instructions")
expect(assistant.tool_choice).to eq("auto")
end

it "passes the block to the original_initialize" do
assigned_block = assistant.instance_variable_get(:@block)
expect(assigned_block).to eq(test_block)
end
end

describe "#save" do
Expand Down
Loading