ProgressBar::WithProgress use #size when available#67
Open
notEthan wants to merge 1 commit intopaul:masterfrom
Open
ProgressBar::WithProgress use #size when available#67notEthan wants to merge 1 commit intopaul:masterfrom
notEthan wants to merge 1 commit intopaul:masterfrom
Conversation
Owner
|
I think this used Is there any reason to use |
Contributor
Author
|
#size is not always defined - the Enumerable module defines #count but not #size; most classes that include Enumerable do define #size, but not all. And the Enumerator class does define #size but it returns nil unless the Enumerator is initialized with a block indicating the size. |
Contributor
Author
|
Think this could make it in? I'm working with large enumerables again and having this in a release would be convenient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #count iterates the enumerable, it can be quite slow. #size is not always available but when it is, it can be much faster than #count.
For some large enumerables I work with, iterating the whole thing takes minutes, so doing it once for count and once for the actual iteration is terribly slow. These use an Enumerator with a block specifying size, and that is computed in relatively insignificant time, so using than when it is available is much better.