This repository was archived by the owner on Nov 27, 2018. It is now read-only.
A fix for scrolling long option lists#17
Open
brandonaaron wants to merge 2 commits intopaulstraw:masterfrom
Open
A fix for scrolling long option lists#17brandonaaron wants to merge 2 commits intopaulstraw:masterfrom
brandonaaron wants to merge 2 commits intopaulstraw:masterfrom
Conversation
… grab the scrollbar and cause a scroll event to happen
Author
|
If you click on the actual scroll bar without dragging, then the scroll event doesn't fire. The original timeout was a bit too quick to allow someone to click it and drag though. So I bumped the blur timeout a bit. |
Owner
|
Brandon, thanks for the PR. I'm going to review and (hopefully) merge it as soon as I have time. |
Author
|
No problem. It isn't a completely ideal solution but I had a client that needed a quick fix. Wish I could devote some more time to it as I think there is still a better solution to be had. |
Owner
|
I'd agree. I wasn't originally using the blur event, which allowed for dealing with this stuff much easier, but had some cross-browser problems. I'll likely merge this in, then eventually refactor to not use blur. We'll see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a quick stab at fixing the scrolling issue on long lists (#9). That is when you go to manually click the scrollbar of the options, the options would actually close. This employs a simple flag when the options are being scrolled and prevents the close event from being trigger when this flag is set.