Update AWS SDK to support EKS container #769
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonet
requested review from
igungor and
ilkinulas
and removed request for
a team
tisonet
force-pushed
the
feature/update-aws-sdk-to-support-eks-container
branch
from
baad886 to
5f8592d
Compare
|
Thank you for opening this PR. I'm running into the same issue. |
|
I have seen the same issue. Could we get this fixed pretty pretty please? @igungor ? |
|
Also faced this issue, @ilkinulas can you help with reviewing this PR please? |
github-merge-queue bot
pushed a commit
to neondatabase/neon
that referenced
this pull request
Dec 19, 2024
## Problem s5cmd doesn't pick up the pod service account ``` 2024/12/16 16:26:01 Ignoring, HTTP credential provider invalid endpoint host, "169.254.170.23", only loopback hosts are allowed. <nil> ERROR "ls s3://neon-dev-bulk-import-us-east-2/import-pgdata/fast-import/v1/br-wandering-hall-w2xobawv": NoCredentialProviders: no valid providers in chain. Deprecated. For verbose messaging see aws.Config.CredentialsChainVerboseErrors ``` ## Summary of changes Switch to offical CLI. ## Testing Tested the pre-merge image in staging, using `job_image` override in project settings. https://neondb.slack.com/archives/C033RQ5SPDH/p1734554944391949?thread_ts=1734368383.258759&cid=C033RQ5SPDH ## Future Work Switch back to s5cmd once peak/s5cmd#769 gets merged. ## Refs - fixes neondatabase/neon-archive-cloud#21876 --------- Co-authored-by: Gleb Novikov <NanoBjorn@users.noreply.github.com>
|
@igungor @ilkinulas Is it possible to get this merged in for a new release? We are using pod-identity credentials for our EKS pods and the minimum version for the AWS Go SDK needs to be greater than v1.47 |
|
@tisonet thanks the for PR. Can you share your compiled binaries? |
|
For those in the same boat: Then it works! |
|
Anything we can do to help this PR get merged? |
|
I can not wait anymore, and create a fork release here: https://github.com/hustcer/s5cmd/releases with many PRs merged, including this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AWS SDK to the latest version to fix issue in EKS containers:
The support for EKS has been added to SDK by this commit aws/aws-sdk-go@bcc4451#diff-33cf96874b95777ed427cc539ea43d9881ee56a8d98a124dbd6d3b71f7c0e10fR128