Add --log-progress flag for log-friendly progress output #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new --log-progress (-lp) flag to the cp command that outputs progress information in a log-friendly format suitable for pipes, log files, and non-TTY environments. Key features: - Outputs to stderr with newlines (not carriage returns) - No ANSI color codes or terminal buffer manipulation - Updates every 2 seconds to avoid log spam - Shows: percentage, bytes transferred/total, speed, ETA, and file count - Format: "Progress: X% - Y/Z @ speed - ETA (N/M files)" This addresses the need for progress reporting in CI/CD pipelines, log files, and other non-interactive environments where the existing --show-progress flag doesn't work. Fixes peak#768 Fixes peak#753
ebrensi
requested review from
denizsurmeli and
igungor
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! the
--show-progressoption fors5cmd cpdoes not work well with logged output. I could not find a way to make it work using wrapper scripts. So I enlisted the help of an AI to make this pull request. Feel free to make modifications to it, as this is just the basic idea. It has been tested and it works.Adds a new --log-progress (-lp) flag to the cp command that outputs progress information in a log-friendly format suitable for pipes, log files, and non-TTY environments.
Key features:
This addresses the need for progress reporting in CI/CD pipelines, log files, and other non-interactive environments where the existing --show-progress flag doesn't work.
Fixes #768
Fixes #753