Initial Snowy, Tintin, and Chalk(?) support for About window #82
Conversation
|
Looks lovely. Does this need changes to the resource pack too? |
|
The script itself is fine, just turned out to be an issue with my code. But I did add 4 new images (it says 3 in my commit, it's actually 4 but I only use 3), and that PR was made here. |
|
https://rebble.io/discord is now a redirect. |
|
Ok, I tested this on tintin, and found that if I scroll down in the about screen, something extremely exciting happens (the whole screen becomes corrupted and the systemapp seems to run out of memory). Can you have a look at that? I think the gbitmaps need to be freed. Other than that, good work! I've merged the resource pack into master. Let me know when you're ready for me to retest and merge. |
Apps/System/systemapp.c
Outdated
| static void about_window_unload(Window *window) | ||
| { | ||
| scroll_layer_destroy(s_about_scroll); | ||
| gbitmap_destroy(logo_color); |
There was a problem hiding this comment.
Note that this only works on color, and breaks on B&W. Recommend just having 'logo' and 'rocket', and conditionally initializing them on B&W and color (and assigning them to NULL); then checking for NULL when you destroy. i.e.,
static GBitmap *logo;
...
logo = create(...);
...
if (logo)
graphics_draw_bitmap_in_rect...
...
if (logo)
gbitmap_destroy(logo);There was a problem hiding this comment.
Great idea, not sure why I didn't think of it. Implemented something similar I think will work, let me know if I need to revise.
|
In my latest commit I added PBL_IF_COLOR_ELSE to pebble_defines.h. This helps with Pebble compatibility and also allows me to do: instead of: |
| s_about_scroll = scroll_layer_create(bounds); | ||
| scroll_layer_set_click_config_onto_window(s_about_scroll, window); | ||
|
|
||
| s_aboutCanvas_layer = layer_create(bounds); |
There was a problem hiding this comment.
caution mixed indentation (we aren't great about this internally righ tnow so I won't block merge on this)
|
Man this is so cool and I'm super excited; I like the thoughtful style change to use I'll merge this now. Thanks again! 🚀 |
2 participants
Recreated from PR #115 in the old project per the request of @jwise
Snowy view
Tintin view
Chalk remains untested, could not get QEMU to boot.
Changes:
TODO: