Skip to content

#66 Oprava přidávání validační class na správný element #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zipper merged 1 commit into from
Aug 25, 2025
Merged

#66 Oprava přidávání validační class na správný element #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/assets/pdForms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,8 +394,6 @@
placeholder = elem.form.querySelector('.pdforms-messages--global');
isGlobal = true;
}

placeholder = placeholder?.querySelector('.pdforms-messages__aria') || placeholder
}

return {
Expand All @@ -419,7 +417,7 @@
* 1. First we try to find elements parent .pdforms-messages--input
* 2. If there is not any, then try to find closest p
* 3. If still no success, try to find .pdforms-messages--global
* 4. If placeholder contains .pdforms-messages__aria, it will be set as placeholder, otherwise we keep placeholder as is
* 4. If placeholder contains .pdforms-messages__aria, message will be inserted into it instead of placeholder element
*
* If two or more inputs with validation rules are in same message placeholder (eg. <p> or .pdforms-messages--input), the
* validation won't work as expected - class .error will be determined by last validated input in the placeholder and
Expand Down Expand Up @@ -475,6 +473,8 @@
msg.setAttribute(tagName === 'label' ? 'for' : 'data-for', elem.id);
}

placeholder.elem = placeholder.elem?.querySelector('.pdforms-messages__aria') || placeholder.elem

placeholder.elem.getAttribute('data-pdforms-messages-prepend') ?
placeholder.elem.insertAdjacentElement('afterBegin', msg) :
placeholder.elem.insertAdjacentElement('beforeEnd', msg);
Expand Down