Alphanumeric housenumber test improvements#568
Merged
missinglink merged 6 commits intomasterfrom Jan 22, 2025
Merged
Conversation
We don't have any firm conventions, but having an endpoint name in the suite name seems to make sense.
For most search queries, the client reading the results may be doing so programatically. Not getting the right result sorted first is almost as bad as not returning it at all.
I don't understand any Cryillic, but it looks like this test has not had a streetname that matches the name in OSM for a while. This appears to be the expected record: https://www.openstreetmap.org/way/431615462
orangejulius
force-pushed
the
alphanumeric-housenumber-test-improvements
branch
from
5261256 to
eaf6374
Compare
Member
|
Added some additional test cases from pelias/pelias#810 (comment) |
missinglink
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little cleanup to our alphanumeric housenumber tests to go with pelias/api#1683 / pelias/query#139.
The major changes are:
priorityThreshto 1, as we really want the desired result to sort firstKinkerstraat 175Fcase from Housenumber with letters results in wrong order pelias#810Minor changes:
14/ain the results and14ain the testAfter pelias/api#1683 the only test we still fail on is
Via del Ponticello 38/2 Trieste italy, where we return a place with housenumber 2, so there's very nice improvement here.