Draft
Conversation
michaelkirk
pushed a commit
to michaelkirk-pelias/openstreetmap
that referenced
this pull request
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT WIP
This PR makes use of pelias/schema#364 to remove the duplication of data between the
address_partsfields and thename.defaultfield.Removing the
address_extractorstream means that noaddresslayer records will be produced.Prior to this PR we would clone
venuerecords to theaddresslayer, and, in fact, we also had support foraccept semi-colon delimited house numbers.So this PR is still WIP, we'd need to give some more consideration to the impact of the above changes before we could merge this.
Related pelias/openaddresses#424