Add Saint/St to street_synonyms_en#452
Closed
orangejulius wants to merge 1 commit intoupdated_street_synonymsfrom
Closed
Add Saint/St to street_synonyms_en#452orangejulius wants to merge 1 commit intoupdated_street_synonymsfrom
orangejulius wants to merge 1 commit intoupdated_street_synonymsfrom
Conversation
This is a common abbreviation that has not been handled well in the `address_parts.street` field. Connects pelias/pelias#737
Joxit
approved these changes
Jun 17, 2020
Member
There was a problem hiding this comment.
Can you also add sainte, ste ? #446 (comment)
This is also related to #301
Member
Author
|
@missinglink informed me he is working on an expansion to #446 that will include lots more multi-lingual synonyms. I think we can make sure |
Member
|
okay ! 👍 |
Merged
Member
Author
|
This is taken care of in #453 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR into #446. We can merge it in directly, test it separately, etc.
It adds a
saint/ststreet synonym. Lack of this synonym on the street field has been a problem for a while, leading to issues such as pelias/pelias#737