Skip to content

Modernize codebase#506

Closed
SiarheiFedartsou wants to merge 3 commits intopelias:masterfrom
SiarheiFedartsou:sf-modernize
Closed

Modernize codebase#506
SiarheiFedartsou wants to merge 3 commits intopelias:masterfrom
SiarheiFedartsou:sf-modernize

Conversation

@SiarheiFedartsou
Copy link
Contributor

👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.


Here's the reason for this change 🚀

What about modernizing codebase of Pelias a bit? It should make maintenance easier.


Here's what actually got changed 👏

  • var -> const/let
  • function -> arrow functions where possible
  • indexOf(...) != -1 -> includes

I used Lebab to automate it.


Here's how others can test the changes 👀

Existing tests :)

@SiarheiFedartsou
Copy link
Contributor Author

SiarheiFedartsou commented Mar 1, 2025

Tbh the change is quite big and I am not sure if maintainers are okay with such size(even though there are no anything complicated), so please feel free to ask to somehow split it.

@SiarheiFedartsou SiarheiFedartsou marked this pull request as ready for review March 1, 2025 17:28
@orangejulius
Copy link
Member

Yeah, in general we do not accept giant contributions to modernize the code.

It's basically impossible to review to ensure a bug or (even worse) a vulnerability did not sneak in.

Sorry.

@orangejulius
Copy link
Member

Oops, sorry to be clear I did not mean to close, just comment. Don't want to seem passive-agressive :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments