Closed
Conversation
Contributor
Author
|
Tbh the change is quite big and I am not sure if maintainers are okay with such size(even though there are no anything complicated), so please feel free to ask to somehow split it. |
Member
|
Yeah, in general we do not accept giant contributions to modernize the code. It's basically impossible to review to ensure a bug or (even worse) a vulnerability did not sneak in. Sorry. |
Member
|
Oops, sorry to be clear I did not mean to close, just comment. Don't want to seem passive-agressive :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
Here's the reason for this change 🚀
What about modernizing codebase of Pelias a bit? It should make maintenance easier.
Here's what actually got changed 👏
I used Lebab to automate it.
Here's how others can test the changes 👀
Existing tests :)