Prepare for PS-3933 (Make Percona Server code compatible with C++11) #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://jira.percona.com/browse/PS-3933 Reimplemented fix for PS-1045 "LP #1654501: libHotBackup.so fails to load on Ubuntu Yakkety 64-bit, debug build" (https://jira.percona.com/browse/PS-1045). Instead of manually specifying '-std=c++03' for 'CMAKE_CXX_FLAGS' we now eliminate the primary source of the problem with unresolved symbol - '-fno-implicit-templates' flag passed to the compiler. This commit also eliminates all explicit class template instantiations from the source code. This step is required to make sure that '-std=xxx' option is set only once in the Percona Server top-level 'CMakeLists.txt' (either explicitly via 'CMAKE_CXX_FLAGS' or implicitly via 'CMAKE_CXX_STANDARD' in newer versions of 'CMake') and is never changed by submodules. This will help to make sure that c++11 options will be propagated properly throughout the project source code and are never rewritten.
laurynas-biveinis
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/PS-3933
Reimplemented fix for PS-1045
"LP #1654501: libHotBackup.so fails to load on Ubuntu Yakkety 64-bit, debug build"
(https://jira.percona.com/browse/PS-1045).
Instead of manually specifying '-std=c++03' for 'CMAKE_CXX_FLAGS' we now
eliminate the primary source of the problem with unresolved symbol -
'-fno-implicit-templates' flag passed to the compiler.
This commit also eliminates all explicit class template instantiations from
the source code.
This step is required to make sure that '-std=xxx' option is set only once in
the Percona Server top-level 'CMakeLists.txt' (either explicitly via
'CMAKE_CXX_FLAGS' or implicitly via 'CMAKE_CXX_STANDARD' in newer versions of
'CMake') and is never changed by submodules. This will help to make sure that
c++11 options will be propagated properly throughout the project source code
and are never rewritten.