Added Pool Defunct functionality #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DefunctPoolInfo and RefundBatchEntry structs to vault.rs - Add new ExecuteMsg variants: DefunctPool, ProcessRefundBatch - Add new QueryMsg variants: GetDefunctPoolInfo, IsUserRefunded - Add storage items: DEFUNCT_POOLS, REFUNDED_USERS - Add error types for defunct pool functionality - Add temporary stubs to contract.rs for compilation - All types compile successfully with tests passing Phase 1 Complete ✅
… - Add DefunctPool and ProcessRefundBatch execute functions - Add GetDefunctPoolInfo and IsUserRefunded query functions - Add defunct pool validation to all pool operations - Add comprehensive test suite with 14 integration tests - All 28 vault tests passing - Core functionality complete, missing only automated reward schedule validation
… Add validate_no_active_reward_schedules() function that queries multistaking contract for active reward schedules - Check common reward assets (uxprt, uatom, uusdc, uosmo) for active schedules - Validate no schedules are currently active (start_time <= current < end_time) - Return PoolHasActiveRewardSchedules error if active schedules found - Added validation call to execute_defunct_pool before processing - Added test_defunct_pool_with_active_reward_schedules test case - All 15 defunct pool tests passing, all 29 total vault tests passing - Critical safety feature prevents defuncting pools with active rewards
…dd V1_2 migration with configurable reward schedule validation assets - Add REWARD_SCHEDULE_VALIDATION_ASSETS storage for customizable asset list - Add PoolHasFutureRewardSchedules error type for future schedule validation - Update validate_no_active_reward_schedules to check both current and future schedules - Add migration handler to set default validation assets during upgrade - Add test for future schedule validation logic - All 16 defunct pool tests passing, all 30 total vault tests passing - Migration allows setting custom validation assets or uses sensible defaults - Future schedule validation prevents defuncting pools with upcoming rewards
betterclever
force-pushed
the
betterclever/pool-defunct
branch
from
04f8791 to
6df7e39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.