Fix: Dark mode not applied because Page instance was not reassigned #188
+17
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
inDarkMode() / inLightMode() return a new Page instance, but the result was not reassigned.
Because of this, the color scheme was never applied and the screenshot test was a false positive.
Fix
Reassign the returned Page instance so the color scheme is actually applied.
Additionally, validate the behavior by asserting scheme-specific content after switching between dark and light modes.
Verification
Verified visually using debug() on macOS
Updated snapshots now correctly differ for light and dark modes
Related
Fixes #1566