Close delete button when editing is over#16
Open
pegurov wants to merge 1 commit intopeter-iakovlev:masterfrom
Open
Close delete button when editing is over#16pegurov wants to merge 1 commit intopeter-iakovlev:masterfrom
pegurov wants to merge 1 commit intopeter-iakovlev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a small UX inaccuracy in the calls list screen.
Calls -> Edit -> Tap one of the minus icons -> Tap Done
Expected behavior: The editing menu of the cell is dismissed together with the editing mode of the whole screen.
Actual behavior: The cell's editing menu is not dismissed.
This problem is present in many screens that allow editing of the list, I just made a fix for this screen.
Has to be merged together with peter-iakovlev/Display#2