add config params that are missing#93
Open
justinvanwinkle wants to merge 3 commits intopeterjc:masterfrom
Open
add config params that are missing#93justinvanwinkle wants to merge 3 commits intopeterjc:masterfrom
justinvanwinkle wants to merge 3 commits intopeterjc:masterfrom
Conversation
Owner
|
Did you mean to read these from the black configuration? |
peterjc
reviewed
Feb 14, 2025
| string_normalization=not black_config.get("skip_string_normalization", False), | ||
| magic_trailing_comma=not black_config.get("skip_magic_trailing_comma", False), | ||
| enable_unstable_feature=config.get("enable_unstable_feature", []), | ||
| unstable=config.get("unstable", False), |
Owner
There was a problem hiding this comment.
See https://github.com/psf/black/blob/25.1.0/src/black/mode.py#L226 which defines the class and https://github.com/psf/black/blob/main/src/black/__init__.py#L626 which initializes it - that's what we try to copy.
This does have unstable as a boolean, but uses enabled_features=set(enable_unstable_feature) (a different argument name to what you are trying).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add config params